[
https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376134#comment-14376134
]
Paul Elschot commented on LUCENE-6308:
--------------------------------------
I took a quick look at the changeapi patch. It looks good to me, and just
comparing the size with the size of the patch of 22 March is enough to see that
it is ok to change the Spans api for this.
But the -1 value for unpositioned needs to be CHANGES.txt for this, as there
are users that use -1 now for other reasons. Another value for unpositioned
might still be possible.
I tested the patch of patch of 22 March also with Integer.MAX_VALUE - 1 for
NO_MORE_POSITIONS to verify that it is not mixed up with NO_MORE_DOCS.
One minor point: there are still a few SpansEnum tests left in the patch.
As to the failing test in the queryparser: probably this is caused by an empty
spans being null and/or the changed initialization of the SpanOr queue.
An empty spans used to be a special object, but the iterator here needs a bit
of its own state even when it is empty, so I changed to using null for an empty
Spans.
With the sentinel values for docs (-1 no doc yet) and positions (-1
unpositioned) the SpanOr queue initialization is also done earlier in the patch
of 22 March.
I'll try the changeapi patch of 23 March to check my guess about the SpanOr
queue.
> SpansEnum, deprecate Spans
> --------------------------
>
> Key: LUCENE-6308
> URL: https://issues.apache.org/jira/browse/LUCENE-6308
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
> Affects Versions: Trunk
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: LUCENE-6308-changeapi.patch, LUCENE-6308.patch,
> LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch,
> LUCENE-6308.patch
>
>
> An alternative for Spans that looks more like PositionsEnum and adds two
> phase doc id iteration
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
