[ https://issues.apache.org/jira/browse/SOLR-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-6350: --------------------------- Attachment: SOLR-6350.patch Xu, your laast patch looked pretty good, but while review & tightening up the tests i noticed a few more improvements. I think this version is ready to commit. Changes since last patch... * alphabetize ive-versions.properties to make precommit happy * added SHA1, LICENSE, and NOTICE for tdigest * reverted unneccessary whitespace changes in CommonParams * added some javadocs to FieldStatsInfo * StatsField... ** switched from ArrayDigest to AVLTreeDigest per recomendations in the t-digest docs ** renamed "compression" localparam to "tdigestCompression" *** as an expert level op, we're assuming they know about the tdigets impl details ** simplified tdigestCompression parsing to leverage SolrParam methods ** renamed "getGetTdigestCompression()" to "getTdigestCompression()" ** corrected getTdigestCompression() return type and local var to be double (not int) * StatsValuesFactory... ** use calculateStats & includeInResponse consistently like all other stats ** remove unused "protected Map<String,String> percentiles = new LinkedHashMap<>()" ** fixed usage of "getGetTdigestCompression()" (new name, see above) ** eliminated smallByteSize() from the serialization logic in addTypeSpecificStats (see comments) * StatsComponentTest... ** testIndividualStatLocalParams *** tightened assertions on individual percentile values ** testPercentiles *** switched to using queryAndResponse so we don't need substring for janky xml parsing *** hardened asserts to ensure exact order of percentiles in response *** simplified asserts that non-numerics don't support percentiles * TestDistributedSearch... ** beefed up assertions ** included sanity testing of FieldStatsInfo.getPercentiles() ---- bq. We should see how we can share some of the implementation here. That sounds like something that would be a much bigger scope then just percentiles, and should be tracked in it's own Jira. > Percentiles in StatsComponent > ----------------------------- > > Key: SOLR-6350 > URL: https://issues.apache.org/jira/browse/SOLR-6350 > Project: Solr > Issue Type: Sub-task > Reporter: Hoss Man > Attachments: SOLR-6350-Xu.patch, SOLR-6350-Xu.patch, > SOLR-6350-xu.patch, SOLR-6350-xu.patch, SOLR-6350.patch, SOLR-6350.patch, > SOLR-6350.patch, SOLR-6350.patch > > > Add an option to compute user specified percentiles when computing stats > Example... > {noformat} > stats.field={!percentiles='1,2,98,99,99.999'}price > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org