[ https://issues.apache.org/jira/browse/LUCENE-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand closed LUCENE-6321. -------------------------------- Resolution: Won't Fix Closing in favor of LUCENE-6369 since we moved away from the original description of the issue. > Make oal.index.Term more defensive > ---------------------------------- > > Key: LUCENE-6321 > URL: https://issues.apache.org/jira/browse/LUCENE-6321 > Project: Lucene - Core > Issue Type: Bug > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Attachments: LUCENE-6321.patch, LUCENE-6321.patch > > > oal.index.Term has a Term(String field, BytesRef termBytes) constructor. Even > though it warns that the term bytes should not be reused, I'm wondering that > we should make it more defensive. > {noformat} > * <p>WARNING: the provided BytesRef is not copied, but used directly. > * Therefore the bytes should not be modified after construction, for > * example, you should clone a copy by {@link BytesRef#deepCopyOf} > * rather than pass reused bytes from a TermsEnum. > {noformat} > For example if you have term queries in your query cache and they are > modified in-place, it would have very bad consequences and would be hard to > diagnose. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org