[ 
https://issues.apache.org/jira/browse/SOLR-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381306#comment-14381306
 ] 

Ishan Chattopadhyaya commented on SOLR-5944:
--------------------------------------------

Thanks for bringing this up. If we're fine with going ahead without dealing 
with reordered updates case, the current patch could be fine. However, it has 
the potential to leave the replicas out of sync, if the user is willing to take 
this risk / informed decision.

I am planning to tackle this more correctly by:
* Making __version__ as a dv field.
* Updates that are distributed to the replicas having "old version" (if any) as 
well as the new version of the doc updated.
* If, upon receiving the update on a replica, the doc version on index/tlog is 
not the "old version" (that means we've missed in update in between to the doc, 
because of reordering), then we can write this update to tlog (and mark it 
somehow as something we're waiting on) but not actually update the doc in the 
index until we receive the update whose update "old version" is what we are 
expecting. After doing this (for all pending updates for the doc), we could 
unmark the documents.
* If we don't receive an update we're waiting for after a reasonable time 
period, we could mark the replica as down.

Also, I had another idea that I like lesser than the above:
For each dv field, we could have a dv version field, and update the document 
partially using just the dv field and its own version field.
There maybe some subtleties I haven't fully thought through with this approach.

> Support updates of numeric DocValues
> ------------------------------------
>
>                 Key: SOLR-5944
>                 URL: https://issues.apache.org/jira/browse/SOLR-5944
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Shalin Shekhar Mangar
>         Attachments: SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, 
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, 
> SOLR-5944.patch, SOLR-5944.patch
>
>
> LUCENE-5189 introduced support for updates to numeric docvalues. It would be 
> really nice to have Solr support this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to