[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383521#comment-14383521 ]
Michael McCandless commented on LUCENE-6308: -------------------------------------------- +1 to the latest patch: it's a great step forward for spans. We can iterate more in the follow-on issues... I think we should commit what we have here now? The patch just needs a minor fix to NearSpans' TwoPhaseIterator now that the approximation is passed to the ctor. It's wonderful that Spans now extends DISI, just adding the position iteration API, and I like adopting the same -1 / Integer.MAX_VALUE sentinels we use for docs iteration. > SpansEnum, deprecate Spans > -------------------------- > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search > Affects Versions: Trunk > Reporter: Paul Elschot > Priority: Minor > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org