[
https://issues.apache.org/jira/browse/LUCENE-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985512#action_12985512
]
Shai Erera commented on LUCENE-2693:
------------------------------------
I reviewed the patch and it no longer applies to DocumentsWriter anymore, since
deletes happen inside SegmentDeletes. So:
# delete-by-term: am I right to say it's handled properly in
SegmentDeletes.addTerm()?
# delete-by-query: seems like SegmentDeletes.addQuery() always increments
bytesUsed, whether the query was already in the map or not. I think that's
wrong, so I'll add a patch that fixes it for you to review.
> Add delete term and query need to more precisely record the bytes used
> ----------------------------------------------------------------------
>
> Key: LUCENE-2693
> URL: https://issues.apache.org/jira/browse/LUCENE-2693
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.9.4, 3.1, 4.0
> Reporter: Jason Rutherglen
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2693.patch
>
>
> DocumentsWriter's add delete query and add delete term add to the number of
> bytes used regardless of the query or term already existing in the respective
> map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
