[
https://issues.apache.org/jira/browse/SOLR-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elaine Cario updated SOLR-6712:
-------------------------------
Attachment: SOLR-6712.patch
I've attached a patch which fixes this issue:
1. Added a test for the combination of group.query and highlighting
2. Added a null check in HighlightComponent - this was causing an existing
prior test to fail before it even got to any of the other distributed grouping
tests, so all the tests should run now. (I didn't trace that back to why
resultIds was null there to begin with, so that could be a deeper bug. The
failing test was running a group.field against an empty index).
3. Made sure QueryComponent didn't empty the resultIds if there were results
for the group query.
I created the patch from the 4.10 branch (not sure which branch to create patch
from, this is my first contribution!).
> Highlighting not working in solr cloud grouping query when using
> group.query=xxx
> --------------------------------------------------------------------------------
>
> Key: SOLR-6712
> URL: https://issues.apache.org/jira/browse/SOLR-6712
> Project: Solr
> Issue Type: Bug
> Components: highlighter
> Affects Versions: 4.10.2
> Reporter: Timo Schmidt
> Attachments: SOLR-6712.patch
>
>
> The highlighting is throwing an exception in sold cloud when you are using
> group.query. Example:
> /select?group=true&group.query=livesuggesttype_s:game_movie&hl=true&hl.q=test&hl.fl=content
> The following exception will be throwen:
> java.lang.NullPointerException
> at
> org.apache.solr.handler.component.HighlightComponent.finishStage(HighlightComponent.java:195)
> at
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:330)
> at
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:1983)
> at
> org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:760)
> at
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:412)
> at
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:201)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1419)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1075)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:384)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1009)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
> at org.eclipse.jetty.server.Server.handle(Server.java:368)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
> at
> org.eclipse.jetty.server.BlockingHttpConnection.handleRequest(BlockingHttpConnection.java:53)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:942)
> at
> org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1004)
> at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:640)
> at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
> at
> org.eclipse.jetty.server.BlockingHttpConnection.handle(BlockingHttpConnection.java:72)
> at
> org.eclipse.jetty.server.bio.SocketConnector$ConnectorEndPoint.run(SocketConnector.java:264)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
> at java.lang.Thread.run(Thread.java:745)
> I think this is also mentioned in the following stackoverflow post:
> http://stackoverflow.com/questions/25548063/solr-search-with-multicore-grouping-highlighting-null-pointer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
