[ https://issues.apache.org/jira/browse/LUCENE-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494160#comment-14494160 ]
Adrien Grand commented on LUCENE-6389: -------------------------------------- One minor thing that annoys me is the array sizing which starts at 256 and then grows. So if we have bugs in the growth logic, it would not be caught by unit tests unless we have more than 256 unique terms. Maybe we could just use 0 as an initial size? This way we don't need to fill it in the constructor and even the simplest unit test would explore the growth code path? Otherwise +1! > Add ScoreMode.Min > ----------------- > > Key: LUCENE-6389 > URL: https://issues.apache.org/jira/browse/LUCENE-6389 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/join > Reporter: Martijn van Groningen > Priority: Minor > Attachments: LUCENE-6389.patch, LUCENE-6389.patch, LUCENE-6389.patch > > > In addition to the existing score modes add 'min' score mode that aggregates > the lowest child score to the parent hit. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org