[ https://issues.apache.org/jira/browse/SOLR-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497904#comment-14497904 ]
Noble Paul commented on SOLR-7110: ---------------------------------- I ran the tests and I consistently got better perf with cache. Attached is the patch to modify the tests to get this output {noformat} THREADS=1 ####### test started w/o cache return=0 THROUGHPUT=217770 ####### test started with cache return=0 THROUGHPUT=275785 cache: hits=18999981 lookups=19000000 size=19 throughput diff numbers per second withcache - withoutcache : 58015 THREADS=2 ####### test started w/o cache return=0 THROUGHPUT=266382 ####### test started with cache return=0 THROUGHPUT=274197 cache: hits=18999981 lookups=19000000 size=19 throughput diff numbers per second withcache - withoutcache : 7815 THREADS=3 ####### test started w/o cache return=0 THROUGHPUT=271296 ####### test started with cache return=0 THROUGHPUT=281373 cache: hits=18999981 lookups=19000000 size=19 throughput diff numbers per second withcache - withoutcache : 10077 THREADS=4 ####### test started w/o cache return=0 THROUGHPUT=268168 ####### test started with cache return=0 THROUGHPUT=282645 cache: hits=18999981 lookups=19000000 size=19 throughput diff numbers per second withcache - withoutcache : 14477 {noformat} > Optimize JavaBinCodec to minimize string Object creation > -------------------------------------------------------- > > Key: SOLR-7110 > URL: https://issues.apache.org/jira/browse/SOLR-7110 > Project: Solr > Issue Type: Improvement > Reporter: Noble Paul > Assignee: Noble Paul > Priority: Minor > Fix For: Trunk, 5.2 > > Attachments: JavabinPerf.patch, SOLR-7110.patch, SOLR-7110.patch, > SOLR-7110.patch > > > In JavabinCodec we already optimize on strings creation , if they are > repeated in the same payload. if we use a cache it is possible to avoid > string creation across objects as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org