[
https://issues.apache.org/jira/browse/LUCENE-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510757#comment-14510757
]
Uwe Schindler edited comment on LUCENE-6450 at 4/24/15 10:49 AM:
-----------------------------------------------------------------
Hi,
looks nice! I have not yet looked fully into it, but I am fine with the
approach in general. I have the same question regarding shifted terms in the
terms enum like Mike.
One small API issue: It is fine to subclass NRQ, but instead of making the
constructor now protected, it should be package private (without access
modifier). The same applies to the inner terms enum class, should be package
protected, too.
The static ctors are needed in NRQ to be able to handle the different data
types. For the geo queries which just have one way to instantiate it, a single,
simple public ctor is ok, no static factory needed.
was (Author: thetaphi):
Hi,
looks nice! I have not yet looked fully into it, but I am fine. I have the same
question regarding shifted terms in the terms enum like Mike.
One small API issue: It is fine to subclass NRQ, but instead of making the
constructor now protected, it should be package private (without access
modifier). The same pplies to the inner terms enum class, should be package
protected, too.
The static ctors are needed in NRQ to be able to handle the different data
types. For the geo queries which just have one way to instantiate them, a
simple public ctor is ok, no static factory needed.
> Add simple encoded GeoPointField type to core
> ---------------------------------------------
>
> Key: LUCENE-6450
> URL: https://issues.apache.org/jira/browse/LUCENE-6450
> Project: Lucene - Core
> Issue Type: New Feature
> Affects Versions: 5.x
> Reporter: Nicholas Knize
> Priority: Minor
> Attachments: LUCENE-6450.patch
>
>
> At the moment all spatial capabilities, including basic point based indexing
> and querying, require the lucene-spatial module. The spatial module, designed
> to handle all things geo, requires dependency overhead (s4j, jts) to provide
> spatial rigor for even the most simplistic spatial search use-cases (e.g.,
> lat/lon bounding box, point in poly, distance search). This feature trims the
> overhead by adding a new GeoPointField type to core along with
> GeoBoundingBoxQuery, GeoPolygonQuery, and GeoDistanceQuery classes to the
> .search package. This field is intended as a straightforward lightweight type
> for the most basic geo point use-cases without the overhead.
> The field uses simple bit twiddling operations (currently morton hashing) to
> encode lat/lon into a single long term. The queries leverage simple
> multi-phase filtering that starts by leveraging NumericRangeQuery to reduce
> candidate terms deferring the more expensive mathematics to the smaller
> candidate sets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
