[
https://issues.apache.org/jira/browse/LUCENE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516947#comment-14516947
]
Adrien Grand commented on LUCENE-6427:
--------------------------------------
bq. Although I agree that oal.util shouldn't become a bag of classes and
methods that might be useful one day, aiming to keep LongBitSet and FixedBitSet
more or less in sync (even though by definition they'll never share the same
interface) shouldn't be too hard.
+1 on that
bq. I only added LongBitSet.flip(long) to be able to make it easier to compare
the TestFixedBitSet and TestLongBitSet files side by side (The main reason why
I removed the import java.util.BitSet from TestLongBitSet as well)
Actually I just noticed that FixedBitSet.flip is unused: it is only used by xor
which is not used.
I'm not happy that I'm delaying your good fixes with concerns around unused
methods so if it works for you, I'll merge your pull-request as-is and will
have a look at removing unused stuff later.
> BitSet fixes - assert on presence of 'ghost bits' and others
> ------------------------------------------------------------
>
> Key: LUCENE-6427
> URL: https://issues.apache.org/jira/browse/LUCENE-6427
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/other
> Reporter: Luc Vanlerberghe
>
> Fixes after reviewing org.apache.lucene.util.FixedBitSet, LongBitSet and
> corresponding tests:
> * Some methods rely on the fact that no bits are set after numBits (what I
> call 'ghost' bits here).
> ** cardinality, nextSetBit, intersects and others may yield wrong results
> ** If ghost bits are present, they may become visible after ensureCapacity is
> called.
> ** The tests deliberately create bitsets with ghost bits, but then do not
> detect these failures
> * FixedBitSet.cardinality scans the complete backing array, even if only
> numWords are in use
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
