[
https://issues.apache.org/jira/browse/LUCENE-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529283#comment-14529283
]
Adrien Grand commented on LUCENE-6372:
--------------------------------------
I really like the additional checks and how hashcode/equals properly call
super.hashcode and only care about members of the class -- not of its parent.
I think my only concern would be that some bit mixes that these queries have in
their hashcode do not have the intended effect now that you changed the order
in which members are incorporated into the hash code (referring to this comment
in particular: {{Mix bits before folding in things like boost}}). It would
probably be safer to move to a multiplicative hash.
> Simplify hashCode/equals for SpanQuery subclasses
> -------------------------------------------------
>
> Key: LUCENE-6372
> URL: https://issues.apache.org/jira/browse/LUCENE-6372
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Paul Elschot
> Attachments: LUCENE-6372.patch
>
>
> Spin off from LUCENE-6308, see the comments there from around 23 March 2015.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
