Hi Uwe, http://pastebin.com/TLfNEnHt
One thing I'm worried about is that it works for anything more than a simple static permissions case. The "sophisticated" ctor requires classloader, but we actually make our own internally. On Wed, May 6, 2015 at 4:01 AM, Uwe Schindler <u...@thetaphi.de> wrote: > Hi, > > I would like to review this - because I was talking with Robert about this > yesterday, but JIRA does not work for me (loads endless so Chrome says: "page > does not respond"). Can you post a link to the patch here? > > Uwe > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: u...@thetaphi.de > > >> -----Original Message----- >> From: Ryan Ernst (JIRA) [mailto:j...@apache.org] >> Sent: Wednesday, May 06, 2015 9:45 AM >> To: dev@lucene.apache.org >> Subject: [jira] [Commented] (LUCENE-6465) Add protectiondomain to >> expressions compiler >> >> >> [ https://issues.apache.org/jira/browse/LUCENE- >> 6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment- >> tabpanel&focusedCommentId=14530102#comment-14530102 ] >> >> Ryan Ernst commented on LUCENE-6465: >> ------------------------------------ >> >> +1 >> >> Do we really need to have so many variants of compile? Could we stick with a >> simple one (just takes the expression text) and one full featured one? It is >> simple for advanced users who need to set protectiond omain to use the >> more advanced one with JavascriptComipiler.DEFAULT_FUNCTIONS and >> JavascriptCompiler.class.getClassLoader()? >> >> > Add protectiondomain to expressions compiler >> > -------------------------------------------- >> > >> > Key: LUCENE-6465 >> > URL: https://issues.apache.org/jira/browse/LUCENE-6465 >> > Project: Lucene - Core >> > Issue Type: Bug >> > Reporter: Robert Muir >> > Attachments: LUCENE-6465.patch >> > >> > >> > Today the classloader is somewhat hidden, you don't have a way to pass >> this. But since we are generating classes on the fly, we should allow it to >> be >> optionally specified. >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v6.3.4#6332) >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional >> commands, e-mail: dev-h...@lucene.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
