[ 
https://issues.apache.org/jira/browse/LUCENE-6468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jun Ohtani updated LUCENE-6468:
-------------------------------
    Attachment: LUCENE-6468.patch

I created the patch for this issue.
Add open(Reader reader) static method to UserDictionary.
And add test empty user dict.

Please review this patch.

> Empty kuromoji user dictionary -> NPE
> -------------------------------------
>
>                 Key: LUCENE-6468
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6468
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6468.patch
>
>
> Kuromoji user dictionary takes Reader and allows for comments and other lines 
> to be ignored. But if its "empty" in the sense of no actual entries, the 
> returned FST will be null, and it will throw a confusing NPE.
> JapaneseTokenizer and JapaneseAnalyzer apis already treat null UserDictionary 
> as having none at all, so I think the best fix is to fix the UserDictionary 
> api from UserDictionary(Reader) to UserDictionary.open(Reader) or similar, 
> and return null if the FST is empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to