[ 
https://issues.apache.org/jira/browse/SOLR-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Thacker updated SOLR-7499:
--------------------------------
    Attachment: SOLR-7499.patch

Patch which ensures that you can't create a replica with a core name that is 
already used for that collection.

Not sure how we would deprecate a param in this case. Just an entry to the 
CHANGES.txt noting the param as deprecated?

> Remove/Deprecate the "name" parameter from the ADDREPLICA Collection API call
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-7499
>                 URL: https://issues.apache.org/jira/browse/SOLR-7499
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Varun Thacker
>            Assignee: Varun Thacker
>            Priority: Minor
>         Attachments: SOLR-7499.patch
>
>
> Right now we take a "name" parameter in the ADDREPLICA call. We use that as 
> the core name for the replica. Are there any use cases where specifying the 
> name of the core for the replica is useful?
> Here are the disadvantages of doing so -
> 1. We don't verify if the name is unique in the collection. So if a 
> conflicting name ends up in the same node then the call will fail.
> 2. If it core is created on some other node, it will fail with 
> legacyCloud=false as that checks for uniqueness in core names.
> https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-api_addreplica
>  - The ref guide has never documented the "name" parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to