[
https://issues.apache.org/jira/browse/LUCENE-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-6486:
---------------------------------------
Attachment: LUCENE-6486.patch
Thanks [~mariusneo]!
I started from your patched and tweaked javadocs / CHANGES wording, and made a
small code style improvement (attached).
Could you add a dedicated test case, e.g. something like
"testPayloadsAreOptional", just to make it clear we intend this functionality?
Also, I'm nervous about pretending we saw a 0-byte payload when the payload was
in fact missing, and also the empty set when no contexts were specified: we
lose information by doing this, e.g. we can no longer distinguish if the
document did in fact have a 0-byte payload.
Can we simply return null (in both cases) when there was no payload or no
context for a given document?
> DocumentDictionary entry iterator skips items with optional null payload field
> ------------------------------------------------------------------------------
>
> Key: LUCENE-6486
> URL: https://issues.apache.org/jira/browse/LUCENE-6486
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.10.3
> Reporter: Marius Grama
> Fix For: Trunk, 5.2
>
> Attachments: LUCENE-6486.patch, LUCENE-6486.patch
>
>
> As denoted in the ticket SOLR-7086 the DocumentDictionary entry iterator
> shouldn't skip entries from the dictionary having null value for the payload
> field due to the fact that this field is optional.
> This behaviour causes inconsistencies in the Solr suggester which simply
> skips valid documents due to the fact that they don't have values for the
> payload field.
> As agreed with [~mikemccand] I am attaching a patch to this Lucene issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
