[
https://issues.apache.org/jira/browse/LUCENE-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548586#comment-14548586
]
Paul Elschot commented on LUCENE-6466:
--------------------------------------
The patch looks good in the sense of making SpanWeight.getSpans() consistent
with Weight.scorer().
This also introduces SpanSimilarity, which makes sense.
On the extra complexity of the SpanWeights that are added for each SpanQuery:
at the moment these SpanWeights don't do much, but they are good to have
because they can be overridden separately.
I think these SpanWeights can also allow adding a scoring method to Spans, but
perhaps that is better done at another issue.
> Move SpanQuery.getSpans() to SpanWeight
> ---------------------------------------
>
> Key: LUCENE-6466
> URL: https://issues.apache.org/jira/browse/LUCENE-6466
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-6466.patch, LUCENE-6466.patch, LUCENE-6466.patch
>
>
> SpanQuery.getSpans() should only be called on rewritten queries, so it seems
> to make more sense to have this being called from SpanWeight
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
