[
https://issues.apache.org/jira/browse/SOLR-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987223#action_12987223
]
Yonik Seeley commented on SOLR-1711:
------------------------------------
Thanks Johannes, the fix does look correct, and I've committed to 3x and trunk.
If we have another release of 1.4, we should backport this.
> Race condition in
> org/apache/solr/client/solrj/impl/StreamingUpdateSolrServer.java
> ----------------------------------------------------------------------------------
>
> Key: SOLR-1711
> URL: https://issues.apache.org/jira/browse/SOLR-1711
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 1.4, 1.5
> Reporter: Attila Babo
> Assignee: Yonik Seeley
> Priority: Critical
> Fix For: 1.4.1, 1.5, 3.1, 4.0
>
> Attachments: StreamingUpdateSolrServer.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> While inserting a large pile of documents using StreamingUpdateSolrServer
> there is a race condition as all Runner instances stop processing while the
> blocking queue is full. With a high performance client this could happen
> quite often, there is no way to recover from it at the client side.
> In StreamingUpdateSolrServer there is a BlockingQueue called queue to store
> UpdateRequests, there are up to threadCount number of workers threads from
> StreamingUpdateSolrServer.Runner to read that queue and push requests to a
> Solr instance. If at one point the BlockingQueue is empty all workers stop
> processing it and pushing the collected content to Solr which could be a time
> consuming process, sometimes all worker threads are waiting for Solr. If at
> this time the client fills the BlockingQueue to full all worker threads will
> quit without processing any further and the main thread will block forever.
> There is a simple, well tested patch attached to handle this situation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
