[ 
https://issues.apache.org/jira/browse/SOLR-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558361#comment-14558361
 ] 

Marius Grama edited comment on SOLR-7566 at 5/25/15 4:16 PM:
-------------------------------------------------------------

Attached a small patch that could possibly be used as solution for this issue.

I think throwing of the exception from HttpShardHandler#submit() method 
(exposed in the above comment) should not be kept anymore in its current form. 
When there are no replica urls available there's no more need to submit the 
callable function.

{code:language=java|title=HttpShardHandler#submit}
final List<String> urls = getURLs(sreq, shard);
if (urls.size()==0) {
    throw new IllegalArgumentException("The shard argument doesn't contain any 
valid URLs. got " + shard);
}
{code}


was (Author: mariusneo):
Attached a small patch that could possibly be used as solution for this issue.

I think throwing of the exception from HttpShardHandler#submit() method 
(exposed in the above comment) should not be kept anymore in its current form. 
When there are no replica urls available there's no more need to submit the 
callable function.

{code:language=java|title=HttpShardHandler#submit}
final List<String> urls = getURLs(sreq, shard);
if (urls.size()==0) {
    throw new IllegalArgumentException("The shard argument doesn't contain any 
valid URLs. got " + shard);
          }
{code}

> Search requests should return the shard name that is down
> ---------------------------------------------------------
>
>                 Key: SOLR-7566
>                 URL: https://issues.apache.org/jira/browse/SOLR-7566
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 5.1
>            Reporter: Shalin Shekhar Mangar
>            Priority: Trivial
>             Fix For: Trunk, 5.2
>
>         Attachments: SOLR-7566.patch
>
>
> If no replicas of a shard are up and running, a search request gives the 
> following response:
> {code}
> {
>   "responseHeader": {
>     "status": 503,
>     "QTime": 2,
>     "params": {
>       "q": "*:*",
>       "indent": "true",
>       "wt": "json",
>       "_": "1432048084930"
>     }
>   },
>   "error": {
>     "msg": "no servers hosting shard: ",
>     "code": 503
>   }
> }
> {code}
> The message should mention the shard which is down/unreachable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to