[
https://issues.apache.org/jira/browse/LUCENE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560979#comment-14560979
]
David Smiley commented on LUCENE-6487:
--------------------------------------
This looks ready to me. I do have a couple lingering thoughts (_not blockers_):
* Might it make sense for Vector to to have it's x, y, and z, plus GeoPoint's
magnitude as floats instead of doubles? I was just thinking the objects are
comparatively heavy compared to a lat-lon based Point.
* It'd be nice if there was some random round-trip tests from lat & lon to
GeoPoint to back again, checking the result is within a tolerance.
[~nknize] do you have an interest in reviewing the Geo3d lucene6487 branch with
respect to WGS84 support?
> Add WGS84 capability to geo3d support
> -------------------------------------
>
> Key: LUCENE-6487
> URL: https://issues.apache.org/jira/browse/LUCENE-6487
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6487.patch, LUCENE-6487.patch, LUCENE-6487.patch,
> LUCENE-6487.patch
>
>
> WGS84 compatibility has been requested for geo3d. This involves working with
> an ellipsoid rather than a unit sphere. The general formula for an ellipsoid
> is:
> x^2/a^2 + y^2/b^2 + z^2/c^2 = 1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
