[
https://issues.apache.org/jira/browse/LUCENE-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561095#comment-14561095
]
Uwe Schindler edited comment on LUCENE-6504 at 5/27/15 2:51 PM:
----------------------------------------------------------------
bq. Its not unrelated, i did extensive benchmarking. That optimization is a
trap, allowing too many low level implementations (3) once the index gets large.
OK. That's fine. I never liked that offset=0 specialization, i think back at
that time we felt it might be a good idea. I don't know the issue number
anymore.
You also removed the negative check in the new Multi implementation; I think
this was done because of performance, too, right? I am not happy with that,
because it no longer throws Exception if you try to access stuff off-slice.
Maybe we can add an "assert" instead?
was (Author: thetaphi):
bq. Its not unrelated, i did extensive benchmarking. That optimization is a
trap, allowing too many low level implementations (3) once the index gets large.
OK. That's fine. I never liked that offset=0 specialization, i think back at
that time we felt it might be a good idea. I don't know the issue number
anymore.
You also removed the negative check in the new Multi implementation, but I
think this was done because of performance, too. I am not happy with that,
because it no longer throws Exception if you try to access stuff off-slice.
Maybe we can add an "assert" instead?
> implement norms with random access API
> --------------------------------------
>
> Key: LUCENE-6504
> URL: https://issues.apache.org/jira/browse/LUCENE-6504
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
> Attachments: LUCENE-6504.patch
>
>
> We added this api in LUCENE-5729 but we never explored implementing norms
> with it. These are generally the largest consumer of heap memory and often a
> real hassle for users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
