[
https://issues.apache.org/jira/browse/LUCENE-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-6507:
--------------------------------
Attachment: LUCENE-6507.patch
Updated patch, fixing SimpleFSLock.close() to be safe as well.
It passed before because tests never use SimpleFSLock. I fixed them to
randomize between Native and Simple in all tests.
This uncovers some new stuff, like this:
{noformat}
[junit4] Suite: org.apache.lucene.index.TestCrashCausesCorruptIndex
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestCrashCausesCorruptIndex -Dtests.method=testCrashCorruptsIndexing
-Dtests.seed=8DBA6BF430E29A48 -Dtests.locale=no_NO_NY
-Dtests.timezone=SystemV/PST8 -Dtests.asserts=true
-Dtests.file.encoding=US-ASCII
[junit4] ERROR 1.37s |
TestCrashCausesCorruptIndex.testCrashCorruptsIndexing <<<
[junit4] > Throwable #1:
org.apache.lucene.store.LockObtainFailedException: Lock obtain timed out:
org.apache.lucene.store.MockDirectoryWrapper$AssertingLock@17e1509f
[junit4] > at
__randomizedtesting.SeedInfo.seed([8DBA6BF430E29A48:FA3DFBC572D35AA3]:0)
[junit4] > at org.apache.lucene.store.Lock.obtain(Lock.java:89)
[junit4] > at
org.apache.lucene.index.IndexWriter.<init>(IndexWriter.java:775)
[junit4] > at
org.apache.lucene.index.TestCrashCausesCorruptIndex.indexAfterRestart(TestCrashCausesCorruptIndex.java:98)
[junit4] > at
org.apache.lucene.index.TestCrashCausesCorruptIndex.testCrashCorruptsIndexing(TestCrashCausesCorruptIndex.java:50)
[junit4] > at java.lang.Thread.run(Thread.java:745)
[junit4] 2> NOTE: leaving temporary files on disk at:
/home/rmuir/workspace/trunk-iw/lucene/build/core/test/J0/temp/lucene.index.TestCrashCausesCorruptIndex
8DBA6BF430E29A48-001
[junit4] 2> NOTE: test params are:
codec=HighCompressionCompressingStoredFields(storedFieldsFormat=CompressingStoredFieldsFormat(compressionMode=HIGH_COMPRESSION,
chunkSize=32683, maxDocsPerChunk=8, blockSize=6),
termVectorsFormat=CompressingTermVectorsFormat(compressionMode=HIGH_COMPRESSION,
chunkSize=32683, blockSize=6)),
sim=RandomSimilarityProvider(queryNorm=false,coord=crazy): {text=DFR GL1},
locale=no_NO_NY, timezone=SystemV/PST8
[junit4] 2> NOTE: Linux 3.13.0-49-generic amd64/Oracle Corporation
1.8.0_45 (64-bit)/cpus=8,threads=1,free=208117928,total=253231104
[junit4] 2> NOTE: All tests run in this JVM: [TestCrashCausesCorruptIndex]
[junit4] Completed [1/1] in 1.55s, 1 test, 1 error <<< FAILURES!
{noformat}
I have not looked into that one yet.
> NativeFSLock.close() can invalidate other locks
> -----------------------------------------------
>
> Key: LUCENE-6507
> URL: https://issues.apache.org/jira/browse/LUCENE-6507
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Simon Willnauer
> Priority: Blocker
> Fix For: 4.10.5, 5.2
>
> Attachments: LUCENE-6507.patch, LUCENE-6507.patch, LUCENE-6507.patch,
> LUCENE-6507.patch, LUCENE-6507.patch, LUCENE-6507.patch
>
>
> the lock API in Lucene is super trappy since the lock that we return form
> this API must first be obtained and if we can't obtain it the lock should not
> be closed since we might ie. close the underlying channel in the NativeLock
> case which releases all lock for this file on some operating systems. I think
> the makeLock method should try to obtain and only return a lock if we
> successfully obtained it. Not sure if it's possible everywhere but we should
> at least make the documentation clear here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
