[ 
https://issues.apache.org/jira/browse/SOLR-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565331#comment-14565331
 ] 

Dawid Weiss commented on SOLR-7601:
-----------------------------------

> We should only check that tests have properly closed resources if the tests 
> passed.

Sorry for noticing this late, Mark. I think you should still try to close any 
resources that may interfere with subsequent tests, just not report all 
failures? Otherwise you run the risk of leaving something that can fail or 
interact with tests executed later.

I think the ideal solution would be for the test runner to detect a failure and 
(optionally) respin the JVM.... 

> We should only check that tests have properly closed resources if the tests 
> passed.
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-7601
>                 URL: https://issues.apache.org/jira/browse/SOLR-7601
>             Project: Solr
>          Issue Type: Test
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: Trunk, 5.3
>
>         Attachments: SOLR-7601.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to