[ 
https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566458#comment-14566458
 ] 

Michael McCandless commented on LUCENE-6508:
--------------------------------------------

These tests are now angry:
{noformat}
mike@haswell:/l/simplelocks$ mike@haswell:/l/simplelocks$    [junit4] Suite: 
org.apache.lucene.store.TestMockDirectoryWrapper
   [junit4]   2> NOTE: reproduce with: ant test  
-Dtestcase=TestMockDirectoryWrapper 
-Dtests.method=testFailIfIndexWriterNotClosed -Dtests.seed=F3213EF45EAF8F1D 
-Dtests.locale=ar_KW -Dtests.timezone=Asia/Chita -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
   [junit4] FAILURE 0.11s J2 | 
TestMockDirectoryWrapper.testFailIfIndexWriterNotClosed <<<
   [junit4]    > Throwable #1: java.lang.AssertionError
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([F3213EF45EAF8F1D:4472AAC3A3E2A5E8]:0)
   [junit4]    >        at 
org.apache.lucene.store.TestMockDirectoryWrapper.testFailIfIndexWriterNotClosed(TestMockDirectoryWrapper.java:55)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> NOTE: reproduce with: ant test  
-Dtestcase=TestMockDirectoryWrapper 
-Dtests.method=testFailIfIndexWriterNotClosedChangeLockFactory 
-Dtests.seed=F3213EF45EAF8F1D -Dtests.locale=ar_KW -Dtests.timezone=Asia/Chita 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
   [junit4] FAILURE 0.02s J2 | 
TestMockDirectoryWrapper.testFailIfIndexWriterNotClosedChangeLockFactory <<<
   [junit4]    > Throwable #1: java.lang.AssertionError
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([F3213EF45EAF8F1D:1980EAD08BE28029]:0)
   [junit4]    >        at 
org.apache.lucene.store.TestMockDirectoryWrapper.testFailIfIndexWriterNotClosedChangeLockFactory(TestMockDirectoryWrapper.java:68)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
{noformat}

We are not tracking openLocks anymore in MDW?

> Simplify Directory/lock api
> ---------------------------
>
>                 Key: LUCENE-6508
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6508
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-6508-deadcode1.patch, LUCENE-6508.patch, 
> LUCENE-6508.patch
>
>
> See LUCENE-6507 for some background. In general it would be great if you can 
> just acquire an immutable lock (or you get a failure) and then you close that 
> to release it.
> Today the API might be too much for what is needed by IW.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to