[ 
https://issues.apache.org/jira/browse/LUCENE-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988076#action_12988076
 ] 

Shai Erera commented on LUCENE-2821:
------------------------------------

Robert, are you sure we can apply the patch to 3x? I'm asking because it breaks 
back-compat. Few protected fields are removed and the Map's signature is 
changed from Map<Integer,FilterItem> to Map<Integer,Filter>. I doubt that 
anyone extends it, but perhaps someone's using it in a way that it will now 
break. Given that we deprecated it and removed in trunk, do you think it's 
worth the break?

> FilterManager starts threads with no way to stop, and should be in 
> contrib/remote, not core
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2821
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2821
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-2821.patch
>
>
> See the warning produced by contrib/remote's tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to