[ 
https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585125#comment-14585125
 ] 

Hrishikesh Gadre commented on SOLR-7344:
----------------------------------------

I think I didn't state my approach clearly. Sorry about that. Here is what I am 
thinking,

- Define a static method in HttpClientUtil which allow us to add a "default" 
request header. This "default" header will be added to all HttpClients created 
in the JVM.
- Invoke this method in the SolrDispatcherFilter::init(...) to add a request 
header Solr-Request-Type => Internal. This will ensure that all HttpClients 
created in the Solr server JVM automatically send this header value for each 
request.
- This will NOT affect the Solrj clients at all (unless someone invokes this 
new method). 

Your other approach of forcing compliance is more correct than what I am 
proposing. The only downside is that it is invasive (which is not bad if we all 
agree to it). I am fine with this approach as well.

Let's finalize the approach so that I can resume the implementation.

> Allow Jetty thread pool limits while still avoiding distributed deadlock.
> -------------------------------------------------------------------------
>
>                 Key: SOLR-7344
>                 URL: https://issues.apache.org/jira/browse/SOLR-7344
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Mark Miller
>         Attachments: SOLR-7344.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to