[
https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585217#comment-14585217
]
Mark Miller commented on SOLR-7344:
-----------------------------------
bq. did this solve the distributed deadlock issue : "maybe not"
Yeah, but you are being obtuse about that. Where do you see the issue? From a
high level, it certainly seems like this solve the issue. Hrishikesh explains
and points to code above. Where is the hole? It looks like you can get the
behavior we need - we will know shortly when the Solr policy is posted I think.
bq. did this address the need to limit concurrent requests without accidentally
decreasing throughput for some request loads (think of the differences between
high fanout and low fanout query request types for example).
Users can still tweak things for individual use cases - we should have limits
that work well for most cases - the default outstanding request limit should
not be that low. No matter what it will be an improvement on the craziness you
can get now with so many threads that get spun up so easily. This approach is a
much better way to handle high load.
bq. did it make life harder for clients
Like I said, nothing so far affects external clients at all - a request that is
not marked can easily be classified as external.
It sounds like you spot a specific issue(s), because a lot is fairly spelled
out above in comments and code, but what is the issue(s)?
> Allow Jetty thread pool limits while still avoiding distributed deadlock.
> -------------------------------------------------------------------------
>
> Key: SOLR-7344
> URL: https://issues.apache.org/jira/browse/SOLR-7344
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: Mark Miller
> Attachments: SOLR-7344.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
