[ https://issues.apache.org/jira/browse/SOLR-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989527#comment-12989527 ]
Ryan McKinley commented on SOLR-1057: ------------------------------------- looks good! I like the tests and configurable delimiter, but maybe we should allow multiple values? In my app, I need to apply this filter to windows paths (C:\path) urls, and unix paths... Maybe this could take a string as an argument with max length 2? then keep delimiter1 and delimiter2, and use: {code:java} if( c == delimiter1 || c == delimiter2 ) { {code} also the javadoc should replace 'somethine' with 'something' > PathTokenizerFactory > -------------------- > > Key: SOLR-1057 > URL: https://issues.apache.org/jira/browse/SOLR-1057 > Project: Solr > Issue Type: New Feature > Components: Schema and Analysis > Reporter: Ryan McKinley > Assignee: Koji Sekiguchi > Priority: Minor > Fix For: 3.1, 4.0 > > Attachments: SOLR-1057-PathTokenizerFactory.patch, > SOLR-1057-PathTokenizerFactory.patch, SOLR-1057.patch > > > This is a Tokenizer that splits the input string into a series of paths. For > example: > {panel} > /aaa/bbb/ccc > {panel} > becomes: > {panel} > /aaa/ > /aaa/bbb/ > /aaa/bbb/ccc > {panel} -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org