[
https://issues.apache.org/jira/browse/LUCENE-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601154#comment-14601154
]
David Smiley commented on LUCENE-6578:
--------------------------------------
I'm not in a hurry to commit anything that has this amount of code redundancy
-- sorry. Now is the time to address it; not in an inevitable future issue.
Apparently Mike feels differently. It's great seeing reduced redundant
javadocs in the latest patch -- thanks. By the way, new patches should
generally be named the same in JIRA.
Karl, a specific idea that would reduce the code here a ton is a simple
interface like:
{code:java}
interface DistCalculator {
double calcDistance(x, y, z);
}
{code}
Then each shape needs... perhaps just a single method taking this? There would
be no extra object allocation per distance run.
> Geo3d: arcDistanceToShape() method may be useful
> ------------------------------------------------
>
> Key: LUCENE-6578
> URL: https://issues.apache.org/jira/browse/LUCENE-6578
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6578.patch, LUCENE-6578.revised.patch
>
>
> I've got an application that seems like it may need the ability to compute a
> new kind of arc distance, from a GeoPoint to the nearest edge/point of a
> GeoShape. Adding this method to the interface, and corresponding
> implementations, would increase the utility of the package for ranking
> purposes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
