[ https://issues.apache.org/jira/browse/LUCENE-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604884#comment-14604884 ]
Robert Muir commented on LUCENE-6630: ------------------------------------- Also, the patch should: * Just use Integer's compare method to sort the array, no custom comparator needed. * Use arrays.binarysearch, not a handcoded binarysearch with overflow bugs. Use of the ternary operator is confusing here. Can the logic be simplified? > Further improve memory of FieldInfos > ------------------------------------ > > Key: LUCENE-6630 > URL: https://issues.apache.org/jira/browse/LUCENE-6630 > Project: Lucene - Core > Issue Type: Bug > Reporter: Ryan Ernst > Attachments: LUCENE-6630.patch > > > In LUCENE-6325, FieldInfos were improved to use an array except in very > sparse cases. In the sparse cases, a TreeMap is still used. However, even in > the sparse case, we can still use an array, and then use binary search. The > perf will be equivalent, but memory use should be much less. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org