[ 
https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615851#comment-14615851
 ] 

Shawn Heisey commented on SOLR-7748:
------------------------------------

I'm going to assume that the way the vendor and version are detected are 
correct, since I don't have an IBM JVM to try.

I did notice in the bash script that the non-IBM option construction included 
an echo command to include the existing GC_LOG_OPTS variable, but for J9, it 
sets the variable and doesn't include what's there previously.  Should that be 
modified to match?  The removed line (replaced with the if/else construct) uses 
parentheses to combine the old with the new, perhaps that method should be used 
in the two new statements.  I'm not an expert either.


> Fix bin/solr to work on IBM J9
> ------------------------------
>
>                 Key: SOLR-7748
>                 URL: https://issues.apache.org/jira/browse/SOLR-7748
>             Project: Solr
>          Issue Type: Bug
>          Components: Server
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: 5.3, Trunk
>
>         Attachments: SOLR-7748.patch, SOLR-7748.patch, solr-7748.patch
>
>
> bin/solr doesn't work on IBM J9 because it sets -Xloggc flag, while J9 
> supports -Xverbosegclog. This prevents using bin/solr to start it on J9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to