Committed revision 1066904.

simon
On Thu, Feb 3, 2011 at 7:10 PM, Simon Willnauer
<[email protected]> wrote:
> FYI - I am about to commit a fix for those failures.
>
> The problem is that the settings for field sort scoring are not
> propagated to the subs
>
>
> Index: lucene/src/java/org/apache/lucene/search/IndexSearcher.java
> ===================================================================
> --- lucene/src/java/org/apache/lucene/search/IndexSearcher.java (revision
> 1066864)
> +++ lucene/src/java/org/apache/lucene/search/IndexSearcher.java (working copy)
> @@ -629,6 +633,11 @@
>   public void setDefaultFieldSortScoring(boolean doTrackScores,
> boolean doMaxScore) {
>     fieldSortDoTrackScores = doTrackScores;
>     fieldSortDoMaxScore = doMaxScore;
> +    if (subSearchers != null) { // propagate settings to subs
> +      for (IndexSearcher sub : subSearchers) {
> +        sub.setDefaultFieldSortScoring(doTrackScores, doMaxScore);
> +      }
> +    }
>   }
>
>   /**
>
>
> On Thu, Feb 3, 2011 at 6:10 PM, Apache Hudson Server
> <[email protected]> wrote:
>> Build: https://hudson.apache.org/hudson/job/Lucene-Solr-tests-only-3.x/4448/
>>
>> 1 tests failed.
>> FAILED:  
>> org.apache.lucene.search.payloads.TestPayloadTermQuery.testIgnoreSpanScorer
>>
>> Error Message:
>> MockDirectoryWrapper: cannot close: there are still open files: {_0.tis=1, 
>> _3.frq=1, _3.tvd=1, _1.frq=1, _3.tvf=1, _3.fdt=1, _2.tvx=1, _3.tvx=1, 
>> _2.tvd=1, _2.tvf=1, _0.prx=1, _3.nrm=1, _0.nrm=1, _1.tvx=1, _1.tis=1, 
>> _2.prx=1, _0.tvd=1, _2.frq=1, _2.fdt=1, _0.tvf=1, _3.prx=1, _2.fdx=1, 
>> _3.fdx=1, _1.prx=1, _1.fdx=1, _1.tvf=1, _2.tis=1, _1.fdt=1, _0.tvx=1, 
>> _0.frq=1, _0.fdx=1, _1.tvd=1, _2.nrm=1, _0.fdt=1, _1.nrm=1, _3.tis=1}
>>
>> Stack Trace:
>> java.lang.RuntimeException: MockDirectoryWrapper: cannot close: there are 
>> still open files: {_0.tis=1, _3.frq=1, _3.tvd=1, _1.frq=1, _3.tvf=1, 
>> _3.fdt=1, _2.tvx=1, _3.tvx=1, _2.tvd=1, _2.tvf=1, _0.prx=1, _3.nrm=1, 
>> _0.nrm=1, _1.tvx=1, _1.tis=1, _2.prx=1, _0.tvd=1, _2.frq=1, _2.fdt=1, 
>> _0.tvf=1, _3.prx=1, _2.fdx=1, _3.fdx=1, _1.prx=1, _1.fdx=1, _1.tvf=1, 
>> _2.tis=1, _1.fdt=1, _0.tvx=1, _0.frq=1, _0.fdx=1, _1.tvd=1, _2.nrm=1, 
>> _0.fdt=1, _1.nrm=1, _3.tis=1}
>>        at 
>> org.apache.lucene.store.MockDirectoryWrapper.close(MockDirectoryWrapper.java:418)
>>        at 
>> org.apache.lucene.search.payloads.TestPayloadTermQuery.tearDown(TestPayloadTermQuery.java:135)
>>        at 
>> org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:1045)
>>        at 
>> org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:977)
>> Caused by: java.lang.RuntimeException: unclosed IndexInput
>>        at 
>> org.apache.lucene.store.MockDirectoryWrapper.openInput(MockDirectoryWrapper.java:373)
>>        at org.apache.lucene.store.Directory.openInput(Directory.java:139)
>>        at 
>> org.apache.lucene.index.TermVectorsReader.<init>(TermVectorsReader.java:79)
>>        at 
>> org.apache.lucene.index.SegmentReader$CoreReaders.openDocStores(SegmentReader.java:299)
>>        at org.apache.lucene.index.SegmentReader.get(SegmentReader.java:580)
>>        at org.apache.lucene.index.SegmentReader.get(SegmentReader.java:556)
>>        at 
>> org.apache.lucene.index.DirectoryReader.<init>(DirectoryReader.java:113)
>>        at 
>> org.apache.lucene.index.ReadOnlyDirectoryReader.<init>(ReadOnlyDirectoryReader.java:29)
>>        at 
>> org.apache.lucene.index.DirectoryReader$1.doBody(DirectoryReader.java:81)
>>        at 
>> org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:736)
>>        at 
>> org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:75)
>>        at org.apache.lucene.index.IndexReader.open(IndexReader.java:428)
>>        at org.apache.lucene.index.IndexReader.open(IndexReader.java:288)
>>        at 
>> org.apache.lucene.search.IndexSearcher.<init>(IndexSearcher.java:97)
>>        at 
>> org.apache.lucene.search.payloads.TestPayloadTermQuery.testIgnoreSpanScorer(TestPayloadTermQuery.java:224)
>>
>>
>>
>>
>> Build Log (for compile errors):
>> [...truncated 4487 lines...]
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to