[ 
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steven Rowe updated LUCENE-2609:
--------------------------------

    Attachment: LUCENE-2609.patch

This patch includes a new POM template for the Lucene test framework.  I ran 
into an issue with circular dependence: Lucene core can't depend on the test 
framework, because the test framework depends on Lucene core.  I solved this 
problem by including {{src/test-framework/}} in Lucene core's test source 
directories, so that no dependency is required on the test framework.  {{ant 
generate-maven-artifacts}} is also modified to include the binary, source, and 
javadoc jars for the test framework.

I tried to make all other modules depend only on the test framework, but 
several Lucene contrib modules refer to Lucene test classes that were not 
included in {{src/test-framework}}: analyzers/common, icu, misc, queryparser, 
and remote.  For these, I kept the previous dependency on the full Lucene tests 
jar.

One other minor change in this patch: the {{jarify}} macro now has an optional 
{{excludes}} attribute that defaults to {{**/pom.xml}}, so that {{pom.xml}} 
files don't end up in any jars.

This patch includes all of Shai's patch, as well as a minor addition mentioned 
by Uwe on IRC: title attributes are included for all test-framework jarify 
calls.  Like Shai's patch, I excluded the moved java files from the patch.


> Generate jar containing test classes.
> -------------------------------------
>
>                 Key: LUCENE-2609
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2609
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 3.0.2
>            Reporter: Drew Farris
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, 
> LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, 
> LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch
>
>
> The test classes are useful for writing unit tests for code external to the 
> Lucene project. It would be helpful to build a jar of these classes and 
> publish them as a maven dependency.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to