[
https://issues.apache.org/jira/browse/SOLR-7825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640504#comment-14640504
]
Oliver Schrenk commented on SOLR-7825:
--------------------------------------
The logging implementations of dependencies can't be changed. As you mentioned
though, not all is lost and these calls can be intercepted. I felt though that
at least core should strive for consistency in its logging usage. There are
actually not so many usages throughout the project
There are some instances in contrib
{code}
contrib/map-reduce/src/java/org/apache/solr/hadoop/MapReduceIndexerTool.java
contrib/map-reduce/src/java/org/apache/solr/hadoop/SolrRecordWriter.java
contrib/map-reduce/src/java/org/apache/solr/hadoop/Utils.java
{code}
or just used by contrib
{code}
core/src/java/org/apache/solr/util/SolrLogLayout.java
{code}
Then there are that are specific to log4j. Im not sure how they are used.
{code}
core/src/java/org/apache/solr/logging/log4j/EventAppender.java
core/src/java/org/apache/solr/logging/log4j/Log4jInfo.java:22
core/src/java/org/apache/solr/logging/log4j/Log4jWatcher.java
{code}
This is standalone
{code}
core/src/java/org/apache/solr/util/SolrCLI.java
{code}
Usages in test
{code}
core/src/test/org/apache/solr/cloud/ConcurrentDeleteAndCreateCollectionTest.java
core/src/test/org/apache/solr/handler/admin/LoggingHandlerTest.java
core/src/test/org/apache/solr/handler/RequestLoggingTest.java
{code}
I just thought I start because the one in ZkContainer was actually a nuisance
to me (because I wasn't aware of {{log4j-over-slf4}}
> Use slf4j consistently
> ----------------------
>
> Key: SOLR-7825
> URL: https://issues.apache.org/jira/browse/SOLR-7825
> Project: Solr
> Issue Type: Improvement
> Components: Server
> Affects Versions: 5.2.1
> Reporter: Oliver Schrenk
> Priority: Minor
> Attachments: slf4j.patch
>
>
> There are a few classes that directly rely on log4j to be on the classpath
> instead and don't use the slf4j logging facade. This creates problems when
> trying to switch the logging implementation.
> 1. org.apache.solr.core.ZkContainer
> https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/core/ZkContainer.java#L218
> I don't know the impact of this change, but shouldn't this call
> `org.apache.solr.logging.MDCLoggingContext.clear()` ?
> 2. org.apache.solr.handler.component.RangeFacetProcessor and
> org.apache.solr.handler.component.RangeFacetRequest
> should use slf4j instead of log4j
> I had a stab at it at
> https://github.com/oschrenk/lucene-solr/commit/025b4802caf0360c63a3554af82e9ed4c94ff5a3#diff-7d822e8ff8ff21d88437652bbc894739R28
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
