[ 
https://issues.apache.org/jira/browse/LUCENE-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640549#comment-14640549
 ] 

ASF subversion and git services commented on LUCENE-6696:
---------------------------------------------------------

Commit 1692533 from [~jpountz] in branch 'dev/trunk'
[ https://svn.apache.org/r1692533 ]

LUCENE-6696: Don't use the forbidden API Collections.shuffle(List).

> FilterDirectoryReader.doClose() should call in.close() not in.doClose()
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-6696
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6696
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 5.3
>
>         Attachments: LUCENE-6696.patch
>
>
> FilterDirectoryReader.doClose() calls in.doClose(). This is wrong because if 
> you call close() on both the underlying reader and a wrapper around it, then 
> doClose() will have been called several times, which will break ref counting.
> Instead, FilterDirectoryReader.doClose() should call in.close() so that it is 
> a no-op if the underlying reader is already closed, or so that calling 
> close() on the underlying reader afterwards will be a no-op.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to