[ https://issues.apache.org/jira/browse/LUCENE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647749#comment-14647749 ]
Nicholas Knize commented on LUCENE-6704: ---------------------------------------- bq. Can you add a dedicated standalone test that today hits OOME and then with this patch doesn't? Sure thing! I'll isolate one of the OOME failures from testRandom() so before/after patch validation can be run. bq. Why is GeoPointDistanceQuery not final anymore? Seems like nothing wants to extend it... That was a change intended for a new issue. I've added a GeoPointDistanceRangeQuery that extends GeoPointDistanceQuery. I'll remove it from this patch and apply it in a new issue. Sorry for that confusion :) > GeoPointInBBox/Distance queries can throw OOME > ---------------------------------------------- > > Key: LUCENE-6704 > URL: https://issues.apache.org/jira/browse/LUCENE-6704 > Project: Lucene - Core > Issue Type: Bug > Reporter: Nicholas Knize > Attachments: LUCENE-6704.patch > > > After investigating LUCENE-6685 the performance issues and improvements > related to GeoPointInBBox/Distance queries could be categorized into two > separate issues: > > 1. OOME caused by an unnecessary number of ranges computed for Point Distance > Queries (bug in the GeoPointTermEnum base class where the bounding box was > used for intersections instead of the point radius) > 2. API improvements providing configurable detail parameters. > This issue addresses 1. LUCENE-6685 will further investigate the need for 2 > (after working 1 and correcting for unnecessary range detail, it looks like 2 > may not be needed) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org