[ 
https://issues.apache.org/jira/browse/SOLR-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649878#comment-14649878
 ] 

Mikhail Khludnev commented on SOLR-6234:
----------------------------------------

Impl notes:

* toString() is a little bit odd, it looks like
{code}
  "debug": {
    "rawquerystring": "{!join from=id to=manu_id_s score=max 
fromIndex=products}inc",
    "querystring": "{!join from=id to=manu_id_s score=max 
fromIndex=products}inc",
    "parsedquery": "OtherCoreJoinQuery(OtherCoreJoinQuery [fromIndex=products, 
fromCoreOpenTime=1438087133575 extends SameCoreJoinQuery [fromQuery=text:inc, 
fromField=id, toField=manu_id_s, scoreMode=Max]])",
    "parsedquery_toString": "OtherCoreJoinQuery [fromIndex=products, 
fromCoreOpenTime=1438087133575 extends SameCoreJoinQuery [fromQuery=text:inc, 
fromField=id, toField=manu_id_s, scoreMode=Max]]",
    "explain": {
{code}
Let me know if you need to change it.

* for cross core join: when you commit into {{fromIndex}} query cache entry 
equality is determined by coreOpenTime() which is obtained from 
{{System.currentTimeMillis()}} it might cause some issues on edge 
cases/plarforms (that's why it wasn't covered with test), but this approach was 
inherited from \{!join}. Raise an issue if it's significant to you. 


> Scoring modes for query time join 
> ----------------------------------
>
>                 Key: SOLR-6234
>                 URL: https://issues.apache.org/jira/browse/SOLR-6234
>             Project: Solr
>          Issue Type: New Feature
>          Components: query parsers
>    Affects Versions: 5.3
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>              Labels: features, patch, test
>             Fix For: 5.3
>
>         Attachments: SOLR-6234-javadocsfix.patch, 
> SOLR-6234-trunk-CHANGES-fix.patch, SOLR-6234.patch, SOLR-6234.patch, 
> SOLR-6234.patch, SOLR-6234.patch, SOLR-6234.patch, SOLR-6234.patch, 
> SOLR-6234.patch, otherHandler.patch
>
>
> it adds ability to call Lucene's JoinUtil by specifying local param, ie  
> \{!join score=...}.... It supports:
> - {{score=none|avg|max|total}} local param (passed as ScoreMode to JoinUtil)
> - -supports {{b=100}} param to pass {{Query.setBoost()}}- postponed till 
> SOLR-7814.
> - -{{multiVals=true|false}} is introduced- YAGNI, let me know otherwise. 
> - there is a test coverage for cross core join case. 
> - so far it joins string and multivalue string fields (Sorted, SortedSet, 
> Binary), but not Numerics DVs. follow-up LUCENE-5868  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to