[ https://issues.apache.org/jira/browse/LUCENE-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651842#comment-14651842 ]
Christine Poerschke commented on LUCENE-6691: --------------------------------------------- Have chosen 'Changes in Runtime Behavior' on the basis that the code is in 'misc' rather than 'core' and {{FilterLeafReader}} previously not being considered is not so much a bug but known-to-be-unsupported behavior. Happy to change to another section though if 'Changes in Runtime Behavior' was the wrong choice. > tweak SortingMergePolicy.getSortDescription > ------------------------------------------- > > Key: LUCENE-6691 > URL: https://issues.apache.org/jira/browse/LUCENE-6691 > Project: Lucene - Core > Issue Type: Test > Reporter: Christine Poerschke > Assignee: Christine Poerschke > Priority: Minor > > Building tests for SOLR-5730 identified that early termination can be omitted > for sorted segments because the {{LeafReader}} concerned is not a > {{SegmentReader}} - github pull request to illustrate to follow: > * the {{TestEarlyTerminatingSortingCollector.testTerminatedEarly}} test uses > a wrapped reader in the same way as {{SolrIndexSearcher}} > * the {{SortingMergePolicy.getSortDescription}} change (assuming it is a > valid change to make) fixes that particular test only > * {{ExitableDirectoryReader}} and {{UninvertingReader}} wrap could perhaps > also be added in {{LuceneTestCase.wrapReader}} ? > LUCENE-6065 "remove "foreign readers" from merge, fix LeafReader instead." > also concerns SortingMergePolicy. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org