[
https://issues.apache.org/jira/browse/SOLR-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652342#comment-14652342
]
Shalin Shekhar Mangar commented on SOLR-5756:
---------------------------------------------
Thanks [~dragonsinth]. This approach looks promising. A few comments on the
patch:
# The return value of updateFromSharedClusterState(clusterState.getLiveNodes(),
null); in ZkStateReader.updateClusterState is discarded. How is the cluster
state updated in that case?
# Perhaps rename StateWatcher.refresh to refreshAndAddWatch to make it more
clear?
# All collections (whether in clusterstate.json or in individual state.json)
having local cores are added to interestingCollections and therefore a
StateWatcher is created even if the collection was in clusterstate.json (as a
result one useless zk call is made?)
# ZkStateReader.removeZKWatch should not remove the collection from the cluster
state just because all local cores belonging to that collection have been
removed. A proper updateClusterState should be called in this case.
This patch has a lot of changes to the way synchronization is done so I will
review it in more detail. But before that, can you please rebase the patch to
trunk?
> A utility API to move collections from internal to external
> -----------------------------------------------------------
>
> Key: SOLR-5756
> URL: https://issues.apache.org/jira/browse/SOLR-5756
> Project: Solr
> Issue Type: Bug
> Reporter: Noble Paul
> Assignee: Shalin Shekhar Mangar
> Attachments: SOLR-5756-vs-5.2.1.patch
>
>
> SOLR-5473 allows creation of collection with state stored outside of
> clusterstate.json. We would need an API to move existing 'internal'
> collections outside
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
