[ 
https://issues.apache.org/jira/browse/SOLR-7855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654439#comment-14654439
 ] 

Gregory Chanan commented on SOLR-7855:
--------------------------------------

Thanks for the feedback Mark.

bq. A lot of cloud code has already kind of cluttered up random packages as it 
was added for various easy at the time reasons - moving towards something nicer 
makes sense to me.

I think the question is whether we move all the overseer related code to the 
cloud.overseer package or not.  Now seemed like a good time because we are 
moving around a bunch of code anyway (which complicates the history to a 
certain extent).  So if we can do it at one time, that's ideal.  I'll 
investigate how feasible that is.

> OverseerCollectionProcessor: separate general task management from collection 
> message handling
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7855
>                 URL: https://issues.apache.org/jira/browse/SOLR-7855
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>         Attachments: SOLR-7855.patch, SOLR-7855.patch
>
>
> While working on SOLR-7789, I realized it would be easier if I split up the 
> OverseerCollectionProcessor into two parts:
> 1) General handling of tasks (work queues, etc)
> 2) Processing a collection handler request
> I haven't decided whether the ConfigSet should have its own processor, i.e. 
> OverseerConfigSetProcessor or reuse at least the thread for the 
> OverseerCollectionProcessor, but in either case this refactoring will be 
> helpful.  That is, if the ConfigSet processing has its own processing, I can 
> reuse the general handling of tasks part.  If the ConfigSet processing reuses 
> the OverseerCollectionProcessing thread, I won't complicate the 
> implementation with ConfigSet operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to