[ https://issues.apache.org/jira/browse/LUCENE-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-6732: ---------------------------------- Attachment: LUCENE-6732.patch Patch. Some files with invalid license headers were fixed already, but I have now like 100 more files to fix: {noformat} -validate-source-patterns: [source-patterns] javadoc-style license header: lucene/analysis/common/src/java/org/apache/lucene/analysis/ar/ArabicAnalyzer.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/java/org/apache/lucene/analysis/bg/BulgarianAnalyzer.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/java/org/apache/lucene/analysis/el/GreekAnalyzer.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/java/org/apache/lucene/analysis/el/GreekLowerCaseFilter.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianAnalyzer.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/java/org/apache/lucene/analysis/hi/HindiAnalyzer.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/java/org/apache/lucene/analysis/th/ThaiAnalyzer.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestStopFilter.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/el/GreekAnalyzerTest.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestScandinavianFoldingFilterFactory.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestScandinavianNormalizationFilterFactory.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/payloads/NumericPayloadTokenFilterTest.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/payloads/TokenOffsetPayloadTokenFilterTest.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/payloads/TypeAsPayloadTokenFilterTest.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/sinks/DateRecognizerSinkTokenizerTest.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/sinks/TestTeeSinkTokenFilter.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/sinks/TokenTypeSinkTokenizerTest.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/test/org/apache/lucene/analysis/snowball/TestSnowballPorterFilterFactory.java [source-patterns] javadoc-style license header: lucene/analysis/common/src/tools/java/org/apache/lucene/analysis/standard/GenerateJflexTLDMacros.java [source-patterns] javadoc-style license header: lucene/analysis/icu/src/java/org/apache/lucene/collation/ICUCollationDocValuesField.java [source-patterns] javadoc-style license header: lucene/analysis/icu/src/test/org/apache/lucene/collation/TestICUCollationDocValuesField.java [source-patterns] javadoc-style license header: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseIterationMarkCharFilter.java [source-patterns] javadoc-style license header: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseIterationMarkCharFilterFactory.java [source-patterns] javadoc-style license header: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseNumberFilter.java [source-patterns] javadoc-style license header: lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseIterationMarkCharFilter.java [source-patterns] javadoc-style license header: lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseNumberFilter.java [source-patterns] javadoc-style license header: lucene/analysis/stempel/src/java/org/apache/lucene/analysis/stempel/StempelFilter.java [source-patterns] javadoc-style license header: lucene/analysis/stempel/src/java/org/apache/lucene/analysis/stempel/StempelStemmer.java [source-patterns] javadoc-style license header: lucene/benchmark/src/java/org/apache/lucene/benchmark/Constants.java [source-patterns] javadoc-style license header: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/AbstractQueryMaker.java [source-patterns] javadoc-style license header: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/FileBasedQueryMaker.java [source-patterns] javadoc-style license header: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/programmatic/Sample.java [source-patterns] javadoc-style license header: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/NewAnalyzerTask.java [source-patterns] javadoc-style license header: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/SearchTravRetLoadFieldSelectorTask.java [source-patterns] javadoc-style license header: lucene/benchmark/src/java/org/apache/lucene/benchmark/utils/ExtractReuters.java [source-patterns] javadoc-style license header: lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilterFactory.java [source-patterns] javadoc-style license header: lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java [source-patterns] javadoc-style license header: lucene/codecs/src/java/org/apache/lucene/codecs/bloom/DefaultBloomFilterFactory.java [source-patterns] javadoc-style license header: lucene/codecs/src/java/org/apache/lucene/codecs/bloom/FuzzySet.java [source-patterns] javadoc-style license header: lucene/codecs/src/java/org/apache/lucene/codecs/bloom/HashFunction.java [source-patterns] javadoc-style license header: lucene/codecs/src/java/org/apache/lucene/codecs/bloom/MurmurHash2.java [source-patterns] javadoc-style license header: lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectPostingsFormat.java [source-patterns] javadoc-style license header: lucene/core/src/java/org/apache/lucene/codecs/StoredFieldsReader.java [source-patterns] javadoc-style license header: lucene/core/src/java/org/apache/lucene/codecs/StoredFieldsWriter.java [source-patterns] javadoc-style license header: lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxQuery.java [source-patterns] javadoc-style license header: lucene/core/src/java/org/apache/lucene/search/spans/TermSpans.java [source-patterns] javadoc-style license header: lucene/core/src/java/org/apache/lucene/util/FilterIterator.java [source-patterns] javadoc-style license header: lucene/core/src/java/org/apache/lucene/util/SmallFloat.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/index/TestAtomicUpdate.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/index/TestByteSlices.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMerging.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/index/TestIndexWriterOnJRECrash.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/index/TestIndexWriterReader.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/index/TestStressDeletes.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/index/TestStressIndexing.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/index/TestStressIndexing2.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/index/TestTermdocPerf.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/search/TestCustomSearcherSort.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/search/payloads/TestPayloadSpans.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/util/Test2BPagedBytes.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/util/TestNumericUtils.java [source-patterns] javadoc-style license header: lucene/core/src/test/org/apache/lucene/util/TestSmallFloat.java [source-patterns] javadoc-style license header: lucene/highlighter/src/java/org/apache/lucene/search/highlight/DefaultEncoder.java [source-patterns] javadoc-style license header: lucene/highlighter/src/java/org/apache/lucene/search/highlight/Encoder.java [source-patterns] javadoc-style license header: lucene/highlighter/src/java/org/apache/lucene/search/highlight/SimpleHTMLEncoder.java [source-patterns] javadoc-style license header: lucene/highlighter/src/java/org/apache/lucene/search/vectorhighlight/WeightedFieldFragList.java [source-patterns] javadoc-style license header: lucene/highlighter/src/java/org/apache/lucene/search/vectorhighlight/WeightedFragListBuilder.java [source-patterns] javadoc-style license header: lucene/highlighter/src/test/org/apache/lucene/search/vectorhighlight/WeightedFragListBuilderTest.java [source-patterns] javadoc-style license header: lucene/misc/src/java/org/apache/lucene/document/LazyDocument.java [source-patterns] javadoc-style license header: lucene/misc/src/java/org/apache/lucene/misc/IndexMergeTool.java [source-patterns] javadoc-style license header: lucene/misc/src/java/org/apache/lucene/uninverting/FieldCacheSanityChecker.java [source-patterns] javadoc-style license header: lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCache.java [source-patterns] javadoc-style license header: lucene/misc/src/test/org/apache/lucene/uninverting/TestFieldCacheSanityChecker.java [source-patterns] javadoc-style license header: lucene/queries/src/java/org/apache/lucene/queries/mlt/MoreLikeThis.java [source-patterns] javadoc-style license header: lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParser.java [source-patterns] javadoc-style license header: lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParserTokenManager.java [source-patterns] javadoc-style license header: lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/processors/BooleanQuery2ModifierNodeProcessor.java [source-patterns] javadoc-style license header: lucene/suggest/src/java/org/apache/lucene/search/spell/NGramDistance.java [source-patterns] javadoc-style license header: lucene/test-framework/src/java/org/apache/lucene/codecs/bloom/TestBloomFilteredLucenePostings.java [source-patterns] javadoc-style license header: solr/contrib/map-reduce/src/java/org/apache/solr/hadoop/HeartBeater.java [source-patterns] javadoc-style license header: solr/contrib/map-reduce/src/java/org/apache/solr/hadoop/SolrMapper.java [source-patterns] javadoc-style license header: solr/contrib/map-reduce/src/java/org/apache/solr/hadoop/SolrOutputFormat.java [source-patterns] javadoc-style license header: solr/contrib/map-reduce/src/java/org/apache/solr/hadoop/SolrRecordWriter.java [source-patterns] javadoc-style license header: solr/contrib/map-reduce/src/java/org/apache/solr/hadoop/SolrReducer.java [source-patterns] javadoc-style license header: solr/contrib/map-reduce/src/java/org/apache/solr/hadoop/Utils.java [source-patterns] javadoc-style license header: solr/contrib/map-reduce/src/java/org/apache/solr/hadoop/ZooKeeperInspector.java [source-patterns] javadoc-style license header: solr/contrib/morphlines-cell/src/java/org/apache/solr/morphlines/cell/SolrCellBuilder.java [source-patterns] javadoc-style license header: solr/contrib/morphlines-core/src/java/org/apache/solr/morphlines/solr/TokenizeTextBuilder.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/search/EarlyTerminatingCollector.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/search/EarlyTerminatingCollectorException.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/search/stats/CollectionStats.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/search/stats/LocalStatsCache.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/search/stats/LocalStatsSource.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/search/stats/StatsCache.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/search/stats/StatsSource.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/search/stats/StatsUtil.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/search/stats/TermStats.java [source-patterns] javadoc-style license header: solr/core/src/java/org/apache/solr/store/blockcache/CachedIndexOutput.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/TestDocumentBuilder.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/cloud/CdcrReplicationHandlerTest.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/search/TestElisionMultitermQuery.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/search/stats/TestBaseStatsCache.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/search/stats/TestDefaultStatsCache.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/search/stats/TestExactSharedStatsCache.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/search/stats/TestExactStatsCache.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/search/stats/TestLRUStatsCache.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/update/AddBlockUpdateTest.java [source-patterns] javadoc-style license header: solr/core/src/test/org/apache/solr/util/PrimUtilsTest.java BUILD FAILED C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1\build.xml:130: 108 source files contain @author javadoc tags, tabs, svn keywords, javadoc-style licenses, or nocommits. Total time: 21 seconds {noformat} This task is about 2 times faster than the old one. > Improve validate-source-patterns in build.xml (e.g., detect invalid license > headers!!) > -------------------------------------------------------------------------------------- > > Key: LUCENE-6732 > URL: https://issues.apache.org/jira/browse/LUCENE-6732 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Attachments: LUCENE-6732.patch > > > Today I enabled warnings analysis on Policeman Jenkins. This scans the build > log for warnings by javac and reports them in statistics, together with > source file dumps. > When doing that I found out that someone added again a lot of "invalid" > license headers using {{/\*\*}} instead a simple comment. This causes > javadocs warnings under some circumstances, because {{/\*\*}} is start of > javadocs and not a license comment. > I then tried to fix the validate-source-patterns to detect this, but due to a > bug in ANT, the {{<containsregexp/>}} filter is applied per line (although it > has multiline matching capabilities!!!). > So I rewrote our checker to run with groovy. This also has some good parts: > - it tells you wwhat was broken, otherwise you just know there is an error, > but not whats wrong (tab, nocommit,...) > - its much faster (multiple {{<containsregexp/>}} read file over and over, > this one reads file one time into a string and then applies all regular > expressions). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org