[
https://issues.apache.org/jira/browse/SOLR-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694643#comment-14694643
]
David Smiley commented on SOLR-7918:
------------------------------------
This is really cool Yonik! I looked over the patch. I have some feedback:
* Was there really any benefit to initializing the FixedBitSet manually versus
simply creating it and calling set() ? If not it's more clear to simply use
the methods on FBS.
* I saw the size threshold numerous times --- {{maxDoc >> 6 + 5}}. Could this
go into a utility method to not repeat yourself?
* The private method createDocSetByIterator appears unused. What's the story
there?
> speed up term->DocSet production
> --------------------------------
>
> Key: SOLR-7918
> URL: https://issues.apache.org/jira/browse/SOLR-7918
> Project: Solr
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Fix For: 5.4
>
> Attachments: SOLR-7918.patch
>
>
> We can use index statistics to figure out before hand what type of doc set
> (sorted int or bitset) we should create. This should use less memory than
> the current approach as well as increase performance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
