[
https://issues.apache.org/jira/browse/SOLR-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-2348:
---------------------------
Attachment: SOLR-2348.patch
Updated patch that fixes the test failures.
For the most part, this is fairly straight forward: tests that were abusing
multiValued fields as if they were single valued.
The one situation where i made a genuine code change was in
AbstractSubTypeFieldType and the way it deals with the "subFieldType"
attribute. When it's used, the registerPolyFieldDynamicPrototype function
registers a new dynamic field based on the specified fieldType instance. I
updated the properties used to generate these dynamicFields so that it
explicitly specifies multiValued=false (it was already specifying indexed=true
and stored=false)
I could have just updated the test schemas so that the fieldType specified was
already multiValued, but i think this makes more sense from a functional
standpoint. the existing code already enabled a use case like this...
{noformat}
<fieldType name="double" class="solr.TrieDoubleField" indexed="false"
multiValued="false" ... />
<fieldType name="xy" class="solr.PointType" dimension="2"
subFieldType="double"/>
{noformat}
...so it makes sense that this should work equally well automatically...
{noformat}
<fieldType name="double" class="solr.TrieDoubleField" indexed="true"
multiValued="true" ... />
<fieldType name="xy" class="solr.PointType" dimension="2"
subFieldType="double"/>
{noformat}
> No error reported when using a FieldCached backed ValueSource for a field
> Solr knows won't work
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-2348
> URL: https://issues.apache.org/jira/browse/SOLR-2348
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Hoss Man
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2348.patch, SOLR-2348.patch
>
>
> For the same reasons outlined in SOLR-2339, Solr FieldTypes that return
> FieldCached backed ValueSources should explicitly check for situations where
> knows the FieldCache is meaningless.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
