[ https://issues.apache.org/jira/browse/LUCENE-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712935#comment-14712935 ]
Greg Huber commented on LUCENE-6570: ------------------------------------ btw, I have multiple contexts so call AnalyzingInfixSuggester.suggester.lookup(term, contexts, nMax, true, true); which will then call AnalyzingInfixSuggester.toQuery(..) eventually, which adds the context with the BooleanClause.Occur.SHOULD. Its a private method so is there a way to override this? private BooleanQuery toQuery(Set<BytesRef> contextInfo) { if (contextInfo == null || contextInfo.isEmpty()) { return null; } BooleanQuery.Builder contextFilter = new BooleanQuery.Builder(); for (BytesRef context : contextInfo) { addContextToQuery(contextFilter, context, BooleanClause.Occur.SHOULD); } return contextFilter.build(); } > Make BooleanQuery immutable > --------------------------- > > Key: LUCENE-6570 > URL: https://issues.apache.org/jira/browse/LUCENE-6570 > Project: Lucene - Core > Issue Type: Task > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Fix For: 5.3, 6.0 > > Attachments: LUCENE-6570.patch > > > In the same spirit as LUCENE-6531 for the PhraseQuery, we should make > BooleanQuery immutable. > The plan is the following: > - create BooleanQuery.Builder with the same setters as BooleanQuery today > (except setBoost) and a build() method that returns a BooleanQuery > - remove setters from BooleanQuery (except setBoost) > I would also like to add some static utility methods for common use-cases of > this query, for instance: > - static BooleanQuery disjunction(Query... queries) to create a disjunction > - static BooleanQuery conjunction(Query... queries) to create a conjunction > - static BooleanQuery filtered(Query query, Query... filters) to create a > filtered query > Hopefully this will help keep tests not too verbose, and the latter will also > help with the FilteredQuery derecation/removal. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org