[ 
https://issues.apache.org/jira/browse/LUCENE-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713598#comment-14713598
 ] 

Michael McCandless commented on LUCENE-6759:
--------------------------------------------

Oh wait, we need to do more than simply disable the assert, because the test 
will still fail, just a bit later when it verifies all hits (the assert was 
just "early detection"):

{noformat}
   [junit4] Suite: org.apache.lucene.bkdtree3d.TestGeo3DPointField
   [junit4]   2> Aug 26, 2015 8:48:39 AM 
com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler
 uncaughtException
   [junit4]   2> WARNING: Uncaught exception in thread: 
Thread[T0,5,TGRP-TestGeo3DPointField]
   [junit4]   2> java.lang.AssertionError: T0: iter=63 id=71226 docID=71226 
lat=-0.004763555725376775 lon=-0.0076479587074575126 expected false but got: 
true deleted?=false
   [junit4]   2>   point1=[lat=-0.004763555725376775, 
lon=-0.0076479587074575126], iswithin=true
   [junit4]   2>   point2=[X=1.0010781049211872, Y=-0.007656353133570567, 
Z=-0.0047688666958216885], iswithin=false
   [junit4]   2>   query=PointInGeo3DShapeQuery: field=point:PlanetModel: 
PlanetModel.WGS84 Shape: GeoCircle: {planetmodel=PlanetModel.WGS84, 
center=[lat=-7.573175600018171E-4, lon=-0.001184769535031697], 
radius=0.007585721238160122(0.4346298115093282)}
   [junit4]   2>        at 
__randomizedtesting.SeedInfo.seed([D75138C6C25D1BCF]:0)
   [junit4]   2>        at org.junit.Assert.fail(Assert.java:93)
   [junit4]   2>        at 
org.apache.lucene.bkdtree3d.TestGeo3DPointField$4._run(TestGeo3DPointField.java:625)
   [junit4]   2>        at 
org.apache.lucene.bkdtree3d.TestGeo3DPointField$4.run(TestGeo3DPointField.java:521)
   [junit4]   2> 
   [junit4]   2> Aug 26, 2015 8:48:40 AM 
com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler
 uncaughtException
   [junit4]   2> WARNING: Uncaught exception in thread: 
Thread[T2,5,TGRP-TestGeo3DPointField]
   [junit4]   2> java.lang.AssertionError: T2: iter=62 id=71226 docID=71226 
lat=-0.004763555725376775 lon=-0.0076479587074575126 expected false but got: 
true deleted?=false
   [junit4]   2>   point1=[lat=-0.004763555725376775, 
lon=-0.0076479587074575126], iswithin=true
   [junit4]   2>   point2=[X=1.0010781049211872, Y=-0.007656353133570567, 
Z=-0.0047688666958216885], iswithin=false
   [junit4]   2>   query=PointInGeo3DShapeQuery: field=point:PlanetModel: 
PlanetModel.WGS84 Shape: GeoCircle: {planetmodel=PlanetModel.WGS84, 
center=[lat=-7.573175600018171E-4, lon=-0.001184769535031697], 
radius=0.007585721238160122(0.4346298115093282)}
   [junit4]   2>        at 
__randomizedtesting.SeedInfo.seed([D75138C6C25D1BCF]:0)
   [junit4]   2>        at org.junit.Assert.fail(Assert.java:93)
   [junit4]   2>        at 
org.apache.lucene.bkdtree3d.TestGeo3DPointField$4._run(TestGeo3DPointField.java:625)
   [junit4]   2>        at 
org.apache.lucene.bkdtree3d.TestGeo3DPointField$4.run(TestGeo3DPointField.java:521)
   [junit4]   2> 
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestGeo3DPointField 
-Dtests.method=testRandomMedium -Dtests.seed=D75138C6C25D1BCF 
-Dtests.multiplier=10 -Dtests.slow=true -Dtests.locale=de_GR 
-Dtests.timezone=America/Managua -Dtests.asserts=true 
-Dtests.file.encoding=US-ASCII
   [junit4] ERROR   62.4s | TestGeo3DPointField.testRandomMedium <<<
{noformat}

So how to correspondingly fix the test?  Right now, in (intentionally) 
quantizes the double x,y,z of the point to match what the doc values 
pack/unpack did ...

Maybe, we could just fix the test so that if isWithin differs between the 
quantized and unquantized x,y,z, we skip checking that hit?

> Integrate lat/long BKD and spatial 3d, part 2
> ---------------------------------------------
>
>                 Key: LUCENE-6759
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6759
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Michael McCandless
>         Attachments: LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch, 
> LUCENE-6699.patch
>
>
> This is just a continuation of LUCENE-6699, which became too big.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to