[ 
https://issues.apache.org/jira/browse/LUCENE-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716888#comment-14716888
 ] 

Michael McCandless commented on LUCENE-6759:
--------------------------------------------

bq. I also changed the encoding max to be exactly WGS84's max.

Hmm, this is now causing test failures, like this:

{noformat}
   [junit4]   2> آب 27, 2015 11:37:34 ص 
com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler
 uncaughtException
   [junit4]   2> WARNING: Uncaught exception in thread: 
Thread[T1,5,TGRP-TestGeo3DPointField]
   [junit4]   2> java.lang.RuntimeException: 
java.lang.IllegalArgumentException: value=1.0011188430720466 is out-of-bounds 
(greater than MAX_VALUE=1.0011188180735464)
   [junit4]   2>        at 
__randomizedtesting.SeedInfo.seed([8CCB7BD6BCA68E54]:0)
   [junit4]   2>        at 
org.apache.lucene.bkdtree3d.TestGeo3DPointField$4.run(TestGeo3DPointField.java:524)
   [junit4]   2> Caused by: java.lang.IllegalArgumentException: 
value=1.0011188430720466 is out-of-bounds (greater than 
MAX_VALUE=1.0011188180735464)
   [junit4]   2>        at 
org.apache.lucene.bkdtree3d.Geo3DDocValuesFormat.encodeValue(Geo3DDocValuesFormat.java:127)
   [junit4]   2>        at 
org.apache.lucene.bkdtree3d.PointInGeo3DShapeQuery$1.scorer(PointInGeo3DShapeQuery.java:115)
   [junit4]   2>        at 
org.apache.lucene.search.LRUQueryCache$CachingWrapperWeight.scorer(LRUQueryCache.java:581)
   [junit4]   2>        at 
org.apache.lucene.search.Weight.bulkScorer(Weight.java:135)
   [junit4]   2>        at 
org.apache.lucene.search.AssertingWeight.bulkScorer(AssertingWeight.java:69)
   [junit4]   2>        at 
org.apache.lucene.search.AssertingWeight.bulkScorer(AssertingWeight.java:69)
   [junit4]   2>        at 
org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:618)
   [junit4]   2>        at 
org.apache.lucene.search.AssertingIndexSearcher.search(AssertingIndexSearcher.java:92)
   [junit4]   2>        at 
org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:425)
   [junit4]   2>        at 
org.apache.lucene.bkdtree3d.TestGeo3DPointField$4._run(TestGeo3DPointField.java:592)
   [junit4]   2>        at 
org.apache.lucene.bkdtree3d.TestGeo3DPointField$4.run(TestGeo3DPointField.java:521)
   [junit4]   2> 
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestGeo3DPointField 
-Dtests.method=testRandomTiny -Dtests.seed=8CCB7BD6BCA68E54 
-Dtests.multiplier=5 -Dtests.slow=true 
-Dtests.linedocsfile=/lucenedata/hudson.enwiki.random.lines.txt.fixed 
-Dtests.locale=ar_LB -Dtests.timezone=US/East-Indiana -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
{noformat}

So at first I thought it's because we do the +/- 2 * MINIMUM_RESOLUTION on the 
top bbox to the BKD tree, so I fixed Geo3DDocValuesFormat.encodeValue to use a 
max of +/- 5 * MINIMUM_RESOLUTION, but the test is still failing.  I guess the 
math that computes a bounding box for a shape can go beyond the planet model's 
min/max?  I'll just add back in a min/max to make sure it's bounded by the 
planet's bounds ...

> Integrate lat/long BKD and spatial 3d, part 2
> ---------------------------------------------
>
>                 Key: LUCENE-6759
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6759
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Michael McCandless
>         Attachments: LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch, 
> LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch
>
>
> This is just a continuation of LUCENE-6699, which became too big.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to