[ 
https://issues.apache.org/jira/browse/LUCENE-6774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727515#comment-14727515
 ] 

Uwe Schindler commented on LUCENE-6774:
---------------------------------------

Setting a context class loader inside "library" code is a big problem and 
should never ever done. It is good that Robert found this problem. The code has 
to be removed, sorry.

Please let us fix the code by:
# first adding a test
# ask [~dweiss] if there were changes he did after this issue in Morphlogik's 
resource loading

If both of this does not work would suggest to:
# let Solr set the context ClassLoader: SOLR-3716
# just load the resource files ourselves and pass them to Dictionary#load(). 
This is mainly because I am not happy that Morfologik uses context ClassLoader 
at all. So I would like to fix this by loading the file ourselves from Class's 
classpath (or in the factory using ResourceLoader as provided by Lucene/Solr).

> Remove solr hack in MorfologikFilter
> ------------------------------------
>
>                 Key: LUCENE-6774
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6774
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 5.3.1
>
>         Attachments: LUCENE-6774.patch
>
>
> If solr wants to set the contextClassLoader because its classloading is 
> fucked up, then it needs to do this hack itself: it should not be in lucene 
> code.
> The current mess prevents use of this analyzer in other environments



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to