[ 
https://issues.apache.org/jira/browse/SOLR-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995591#comment-12995591
 ] 

Hoss Man commented on SOLR-2365:
--------------------------------

+1

we need to make sure to call this out at the top of CHANGES.txt so people 
upgrading from 1.x know they *must* modify their solrconfig.xml (to add the 
{{<lib/}} directive) if they use DIH ... but yeah, if it doesn't need to be in 
hte war for that JSP to work, then let's keep it as an isolated contrib jar.

> DIH should not be in the Solr war
> ---------------------------------
>
>                 Key: SOLR-2365
>                 URL: https://issues.apache.org/jira/browse/SOLR-2365
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2365_DIH_should_not_be_in_war.patch
>
>
> The DIH has a build.xml that puts itself into the Solr war file.  This is the 
> only contrib module that does this, and I don't think it should be this way. 
> Granted there is a small dataimport.jsp file that would be most convenient to 
> remain included, but the jar should not be.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to