[
https://issues.apache.org/jira/browse/LUCENE-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736347#comment-14736347
]
Uwe Schindler commented on LUCENE-6770:
---------------------------------------
getLockId was not related to that. It was completely unused. In earlier Lucene
version this was used to create the lock file outside the index directory
(e.g., in /tmp). For that it created a hash code that was included into file
name. This is no longer possible, lock files are in index directory. This
method was not used anymore.
The real path is needed not for creating the lock file, it is needed for
identifying the lock in the same JVM based on a unique key (so its similar but
still different).
> FSDirectory ctor should use getAbsolutePath instead of getRealPath for
> directory
> --------------------------------------------------------------------------------
>
> Key: LUCENE-6770
> URL: https://issues.apache.org/jira/browse/LUCENE-6770
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/store
> Affects Versions: 5.2.1
> Environment: OS X, Linux
> Reporter: Vladimir Kuzmin
> Assignee: Uwe Schindler
> Attachments: LUCENE-6770.patch
>
>
> After upgrade from 4.1 to 5.2.1 I found that one of our test failed. Appeared
> the guilty was FSDirectory that converts given Path to Path.getRealPath. As
> result the test will fail:
> Path p = Paths.get("/var/lucene_store");
> FSDirectory d = new FSDirectory(p);
> assertEquals(p.toString(), d.getDirectory().toString());
> It because /var/lucene_store is a symlink and
> Path directory =path.getRealPath();
> resolves it to /private/var/lucene_store
> I think this is bad design decision because "direcrory" isn't just internal
> state but is exposed in a public interface and "getDirectory()" is widely
> used to initialize other components.
> It should use paths.getAbsolutePath() instead.
> build and "ant test" were successful after fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
