[ 
https://issues.apache.org/jira/browse/SOLR-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Miller updated SOLR-8069:
------------------------------
    Attachment: SOLR-8069.patch

Well here is one approach.

In either case, I'd like to add the checks against CloudDescriptor#isLeader - 
this is our most up to date and real time information about whether or not we 
are connected to zk and think we are the leader - if this is false, we don't 
want to do anything that a leader should do. If we are going to have best 
effort checks against zk itself to ensure we are still the leader, this 
important defensive check should also generally be included.

Otherwise, I think the current code does not really work - it's really easy to  
grab the latest context and the latest context should usually look right? This 
code addresses that rather large hole. I'm open to doing more, but I have not 
grasped the full implementation of it yet given the state available to the 
various LIR methods.

> Leader Initiated Recovery can put the replica with the latest data into LIR 
> and a shard will have no leader even on restart.
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8069
>                 URL: https://issues.apache.org/jira/browse/SOLR-8069
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>         Attachments: SOLR-8069.patch, SOLR-8069.patch
>
>
> I've seen this twice now. Need to work on a test.
> When some issues hit all the replicas at once, you can end up in a situation 
> where the rightful leader was put or put itself into LIR. Even on restart, 
> this rightful leader won't take leadership and you have to manually clear the 
> LIR nodes.
> It seems that if all the replicas participate in election on startup, LIR 
> should just be cleared.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to